Skip to content

Make emit-module-separately the default incremental build mode #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2021
Merged

Make emit-module-separately the default incremental build mode #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
74aee03
Make emit-module-separately the default incremental build mode
xymus Jun 15, 2021
21bd47d
[Tests] Update tests for emit-module-separately by default
xymus Jun 16, 2021
bcea5d4
Remove prints from SwiftDriverTests that were appearing at the end of…
xymus Sep 1, 2021
b18f7c0
Don't emit-module for calls with non-swift source files as inputs
xymus Sep 9, 2021
b12b94e
Accept SIL files as inputs for emit-module-separately
xymus Sep 9, 2021
582e81a
Pass along the symbol-graph flags with emit-module
xymus Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/SwiftDriver/Jobs/EmitModuleJob.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ extension Driver {

addCommonModuleOptions(commandLine: &commandLine, outputs: &outputs, isMergeModule: false)

try commandLine.appendLast(.emitSymbolGraph, from: &parsedOptions)
try commandLine.appendLast(.emitSymbolGraphDir, from: &parsedOptions)

if parsedOptions.hasArgument(.parseAsLibrary, .emitLibrary) {
commandLine.appendFlag(.parseAsLibrary)
}
Expand All @@ -102,6 +105,7 @@ extension Driver {
var shouldCreateEmitModuleJob: Bool {
mutating get {
return moduleOutputInfo.output != nil
&& inputFiles.allSatisfy() { $0.type.isPartOfSwiftCompilation } // Ignore calls for linking.
&& (forceEmitModuleBeforeCompile
|| shouldEmitModuleSeparately())
}
Expand All @@ -111,7 +115,7 @@ extension Driver {
mutating func shouldEmitModuleSeparately() -> Bool {
return parsedOptions.hasFlag(positive: .emitModuleSeparately,
negative: .noEmitModuleSeparately,
default: false)
default: true)
&& !parsedOptions.hasFlag(positive: .wholeModuleOptimization,
negative: .noWholeModuleOptimization,
default: false)
Expand Down
Loading