Skip to content

test: skip testAPIComparisonEndToEnd() while investigating #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

test: skip testAPIComparisonEndToEnd() while investigating #818

merged 1 commit into from
Sep 2, 2021

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Sep 1, 2021

rdar://82302797

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Sep 1, 2021

@swift-ci please test

@nkcsgexi nkcsgexi mentioned this pull request Sep 1, 2021
Merged
@artemcm
Copy link
Contributor

artemcm commented Sep 1, 2021

@swift-ci please test

@artemcm artemcm mentioned this pull request Sep 1, 2021
Closed
@artemcm
Copy link
Contributor

artemcm commented Sep 1, 2021

Ah, this XCTSkip is on the wrong test. It needs to be on testABIComparisonEndToEnd, not testAPIComparisonEndToEnd.

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Sep 1, 2021

@swift-ci please test

@artemcm
Copy link
Contributor

artemcm commented Sep 1, 2021

I guess it needs to be on both, sorry. :(

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Sep 1, 2021

@swift-ci please test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Sep 1, 2021

@artemcm no worries at all. Thanks for pinging!

@artemcm artemcm merged commit 2459e7d into swiftlang:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkcsgexi @artemcm