Turn on emit-module-separately for whole-module builds by default #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheduling a separate emit-module job for whole-module builds, combined with the integrated driver in the build system, will allow to parallelize what used to be essentially sequential builds. This mode unblocks building dependents early by duplicating some work in two processes, it requires more cpu work for a faster wall clock build time. Another advantage of this mode is the resulting swiftmodule is lighter from a classic whole-module build. rdar://85976762
|
I put this up as is to run tests. I expect this to break a lot of tests, here and in the compiler. @swift-ci Please test |
|
@swift-ci Please test |
|
@swift-ci Please test |
|
More tests are failing this time, it's a good sign. The first version scheduled the separate emit-module job only when the |
xymus
force-pushed
the
ems-wmo-by-default
branch
from
3e2658d to
e0db4cb
Compare
|
@swift-ci Please test |
xymus
force-pushed
the
ems-wmo-by-default
branch
from
e0db4cb to
d887353
Compare
|
@swift-ci Please test |
|
The tests look good here and on the compiler side. I think this is ready for review! |
nkcsgexi
approved these changes
Dec 17, 2021
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduling a separate emit-module job for whole-module builds, combined with the integrated driver in the build system, will allow to parallelize what used to be essentially sequential builds. This mode unblocks building dependents early by duplicating some work in two processes, it requires more cpu work for a faster wall clock build time. Another advantage of this mode is the resulting swiftmodule is lighter from a classic whole-module build.
rdar://85976762