Loosen restriction for building deprecated iOS targets #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
approved these changes
Jan 26, 2022
|
I launched the tests from the compiler side because there's an equivalent check in the C++ driver so there could be tests affected there too. |
xymus
reviewed
Jan 26, 2022
| XCTFail() | ||
| return | ||
| } | ||
| } | ||
|
|
||
| XCTAssertThrowsError(try Driver(args: ["swiftc", "-emit-module", "-c", "-target", | ||
| "armv7-apple-ios12.0", "foo.swift"])) { error in |
There was a problem hiding this comment.
Should we test a version without the -c where there's no error?
cyndyishida
force-pushed
the
backDeploymentBuilds
branch
from
2615e52 to
3cd581b
Compare
|
@swift-ci please test |
cyndyishida
force-pushed
the
backDeploymentBuilds
branch
2 times, most recently
from
4469731 to
1fe3ec5
Compare
|
@swift-ci please test |
| return "iOS \(version) does not support 32-bit programs" | ||
| case .invalidDeploymentTargetForIR(let target): | ||
| return | ||
| "\(target) and above does not support emitting binaries or IR for 32-bit programs" |
There was a problem hiding this comment.
Could we pass through and print the specific architecture name in place of "32-bit" in order to be more generalized?
There was a problem hiding this comment.
This is updated to emit "iOS 11 and above does not support emitting binaries or IR for armv7" for armv7-apple-ios12
lorentey
approved these changes
Jan 27, 2022
cyndyishida
force-pushed
the
backDeploymentBuilds
branch
from
1fe3ec5 to
93bd0b2
Compare
|
@swift-ci please test |
This patch loosens the restriction for building deprecated iOS targets to only when the user attempts to compile a binary or emit IR. This allows the compiler to continue building swift modules and interfaces for newer deployment targets. The error message is also slightly modified to allow the same message to apply to different platforms. resolves: <rdar://87898177>
cyndyishida
force-pushed
the
backDeploymentBuilds
branch
from
93bd0b2 to
4d847b9
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch loosens the restriction for building deprecated iOS targets
to only when the user attempts to compile a binary or emit IR.
This allows the compiler to continue building swift modules and
interfaces for newer deployment targets.
The error message is also slightly modified to allow the same message to
apply to different platforms.
resolves: rdar://87898177