[stm32-lvgl] Fix an interrupt safety bug that caused occasional crashes #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,13 +69,23 @@ func SystickTimerISR() { | |||
| uptimeInMs += 1 | |||
| } | |||
|
|
|||
| // The following interrupt set up is trickier that it looks on the surface. The | |||
There was a problem hiding this comment.
Suggested change
| // The following interrupt set up is trickier that it looks on the surface. The | |
| // The following interrupt set up is trickier than it looks on the surface. The |
| // ISR Swift code must be "trivial" directly and transitively, and namely it | ||
| // must avoid destroying any heap objects (because we could be inside malloc | ||
| // when the interrupt hits). For that, the expectation is that | ||
| // lcdInterruptVerticalSyncHandler is only ever set once, and it not changing |
There was a problem hiding this comment.
Suggested change
| // lcdInterruptVerticalSyncHandler is only ever set once, and it not changing | |
| // lcdInterruptVerticalSyncHandler is only ever set once, and it is not changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the added comment that explains the bug.