Add a proposal for count(where:) #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasThomas
reviewed
Apr 23, 2018
|
|
||
| Counting the number of objects that pass a test has a wide range of uses in many domains. However, Swift currently doesn't give its users a simple way to perform this operation. While the behavior can currently be approximated with a `filter` and a `count`, this approach creates an intermediate array which it immediately discards. This is a bit wasteful. | ||
|
|
||
| [1, 2, 3, -1, -2].filter({ $0 > 0 }).count // => 3 |
There was a problem hiding this comment.
You can, instead of adding the four spaces, wrap these in backticks (```) and add syntax highlighting (```swift on the first line)
|
Just double checking on the status of this! Anything else I can do to push it forward? |
|
This review is going to be scheduled for the week of August 6. |
|
That sounds great. Thanks for heads up, Ted! |
|
Why not use My specific point in raising this is that it bypasses the "extra intermediate array" concern (for |
|
Scheduled for review August 6 - 12, 2018 |
|
Now AKA SE-0220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for
count(where:).Pitch thread: https://forums.swift.org/t/count-where-on-sequence/11186
Recommended implementation: swiftlang/swift#16099