[SE-0206] Incorporate acceptance notes; set status to Implemented #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Hasher.init(seed:) - Remove most Hasher.combine overloads - Change Hasher.finalize to be __consuming - Clarify that Hasher is order-sensitive - Clarify hashValue's deprecated status (only custom implementations are deprecated) - Clarify that SE-0206 is *not* going to be source-breaking; hashValue impls will compile with a warning in 4.2 mode.
|
@jckarter This incorporates the changes in the core team's acceptance notes, and also clarifies that while The old Source Compatibility section implied that users will need to go through a forced migration step, which is not the case. I replaced it with text that describes the actual intended behavior. swiftlang/swift#16009 and swiftlang/swift#16073 implemented the proposal. (Except for the deprecation warning when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hasher.init(seed:)Hasher.combineoverloadsHasher.finalizeto be__consumingHasheris order-sensitivehashValue's deprecated status (only custom implementations are deprecated)hashValueimpls will compile with a warning in 4.2 mode.