Skip to content

[swift/main] Adds SPI for a NSRE compatibility mode option (#698) #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

natecook1000
Copy link
Member

NSRegularExpression matches at the Unicode scalar level, but also matches \r\n sequences with a single . when single-line mode is enabled. This adds a _nsreCompatibility property that enables both of those behaviors, and implements support for the special case handling of ..

Cherry pick of #698.

@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 requested a review from milseman December 1, 2023 22:41
@natecook1000
Copy link
Member Author

@swift-ci Please test Windows platform

NSRegularExpression matches at the Unicode scalar level, but also
matches `\r\n` sequences with a single `.` when single-line mode is
enabled. This adds a `_nsreCompatibility` property that enables both
of those behaviors, and implements support for the special case
handling of `.`.
@natecook1000 natecook1000 force-pushed the swiftmain_nsre_compat branch from f740948 to 99525b2 Compare December 5, 2023 20:34
@natecook1000
Copy link
Member Author

@swift-ci Please test macOS platform
@swift-ci Please test Linux platform

@natecook1000
Copy link
Member Author

@swift-ci Please test macOS platform

@justice-adams-apple
Copy link

@swift-ci Please test Windows platform

1 similar comment
@natecook1000
Copy link
Member Author

@swift-ci Please test Windows platform

@natecook1000 natecook1000 merged commit 42678d5 into swiftlang:swift/main Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants