[perf] Implement auto-possessification #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimization recognizes quantifications followed by an atom that can't be matched at the start of the quantification, and converts them to possessive, eliminating any backtracking at that position. This change includes an accessor for the first "required" atom (which will be used in other optimizations), and converts DSL.QuantificationKind to a struct to support the possessification changes.
When deciding on exclusion during auto-possessification, awareness of the current matching options is important for correct analysis. For example, /a+A/ can be auto-possessified, but the case insensitive pattern /(?i)a+A/ cannot be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization recognizes quantifications followed by an atom that can't be matched at the start of the quantification, and converts them to possessive, eliminating any backtracking at that position. This change includes an accessor for the first "required" atom (which will be used in other optimizations), and converts DSL.QuantificationKind to a struct to support the possessification changes.