Merge pull request #424 from apple/revert-generate-pipeline-plugin

Author: DougGregor

Documentation/Development.md

@@ -1,5 +1,31 @@
 # Developing `swift-format`
 
+## Keeping the Pipeline and Tests Updated
+
+Since Swift does not yet have a runtime reflection system, we use code
+generation to keep the linting/formatting pipeline up-to-date. If you add or
+remove any rules from the `SwiftFormatRules` module, or if you add or remove
+any `visit` methods from an existing rule in that module, you must run the
+`generate-pipeline` tool update the pipeline and configuration sources.
+
+The easiest way to do this is to run the following command in your terminal:
+
+```shell
+swift run generate-pipeline
+```
+
+If successful, this tool will update
+`Sources/SwiftFormatConfiguration/RuleRegistry+Generated.swift` and
+`Sources/SwiftFormat/Pipelines+Generated.swift`.
+
+Likewise, you should keep the Linux XCTest manifests updated if you add or
+remove any tests from `swift-format` by running the following command in your
+terminal:
+
+```shell
+swift test --generate-linuxmain
+```
+
 ## Command Line Options for Debugging
 
 `swift-format` provides some hidden command line options to facilitate

Package.swift

@@ -48,12 +48,10 @@ let package = Package(
         .product(name: "SwiftSyntax", package: "swift-syntax"),
         .product(name: "SwiftOperators", package: "swift-syntax"),
         .product(name: "SwiftParser", package: "swift-syntax"),
-      ],
-      plugins: ["generate-pipeline-plugin"]
+      ]
     ),
     .target(
-      name: "SwiftFormatConfiguration",
-      plugins: ["generate-pipeline-plugin"]
+      name: "SwiftFormatConfiguration"
     ),
     .target(
       name: "SwiftFormatCore",
@@ -65,8 +63,7 @@ let package = Package(
     ),
     .target(
       name: "SwiftFormatRules",
-      dependencies: ["SwiftFormatCore", "SwiftFormatConfiguration"],
-      plugins: ["generate-pipeline-plugin"]
+      dependencies: ["SwiftFormatCore", "SwiftFormatConfiguration"]
     ),
     .target(
       name: "SwiftFormatPrettyPrint",
@@ -93,22 +90,15 @@ let package = Package(
       ]
     ),
 
-    .plugin(
-      name: "generate-pipeline-plugin",
-      capability: .buildTool(),
-      dependencies: [
-        "generate-pipeline"
-      ]
-    ),
     .executableTarget(
       name: "generate-pipeline",
       dependencies: [
-        .product(name: "ArgumentParser", package: "swift-argument-parser"),
+        "SwiftFormatCore",
+        "SwiftFormatRules",
         .product(name: "SwiftSyntax", package: "swift-syntax"),
         .product(name: "SwiftParser", package: "swift-syntax"),
       ]
     ),
-
     .executableTarget(
       name: "swift-format",
       dependencies: [