Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert generate pipeline plugin #424

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

DougGregor
Copy link
Member

Revert #416 and #419 because they appear to be breaking Swift pull request testing.

@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@allevato this revert PR is because we think #416 and #419 are causing the silent SwiftSyntax build failures we're seeing in Swift CI. The referenced PR (swiftlang/swift#61545) is where we're testing out this theory.

@allevato
Copy link
Member

@ahoppen mentioned this to me as well. Given the issue on Windows as well (#422) maybe this is the best option if we confirm that it's the problem.

Any idea why the plug-in is causing the failures?

If we had the swift-ci trigger working on this repo, would it have caught the problem before it was merged? cc @shahmishal

Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and approve this just in case; feel free to merge it if your testing confirms the plugin was the problem, and let me know if there's anything I can do to help get it working again after that!

@DougGregor
Copy link
Member Author

Yeah, I've confirmed that the plug-in was the problem, so I'm going to go ahead and merge. Sorry about that--let's look for a path forward, because this is a nice cleanup and it's unfortunate we have to revert.

@DougGregor DougGregor merged commit aeac83e into main Oct 12, 2022
@DougGregor DougGregor deleted the revert-generate-pipeline-plugin branch October 12, 2022 19:32
@ahoppen
Copy link
Member

ahoppen commented Oct 13, 2022

If we had the swift-ci trigger working on this repo, would it have caught the problem before it was merged? cc @shahmishal

I think what you can do in the meantime while CI triggers are not set up for this repo, is to create a fake PR to https://github.com/apple/swift/, mention the swift-format PR you want to test and add @swift-ci Please test (or your favorite test invocation). I am often doing this in swiftlang/swift#37710.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants