Revert the use of generate-pipeline-plugin on Windows platforms.
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This temporarily removes the use of the plugin only on Windows, where it is not working properly due to a likely bug in SPM. We can keep the files checked in for now and updated using the `Scripts/generate-all-pipelines.sh` script, and those files will be ignored on other platforms (the plugin will still be used there). Fixes swiftlang#422.
|
@compnerd , can you please try this out? |
|
FWIW, ignoring #424, this almost works. swift-argument-parser doesn't build, but that seems unrelated to this? The tests also pass. |
|
Closing this in light of #424. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporarily removes the use of the plugin only on Windows, where it is not working properly due to a likely bug in SPM. We can keep the files checked in for now and updated using the
Scripts/generate-all-pipelines.shscript, and those files will be ignored on other platforms (the plugin will still be used there).Fixes #422.