Improve XCTest import detection logic.
#417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, this will now find imports of specific decls (e.g., `import class XCTest.XCTestCase`) and imports inside `#if` blocks. Also add some tests specifically for this logic, instead of testing it only in the context of other rules. Fixes swiftlang#403.
|
cc @dylansturg |
dylansturg
approved these changes
Oct 11, 2022
| import SwiftParser | ||
| import XCTest | ||
|
|
||
| class ImportsXCTestVisitorTests: DiagnosingTestCase { |
There was a problem hiding this comment.
Would attributes like @_implementationOnly effect the decl? Might add a test case that has an attribute on the XCTest import.
There was a problem hiding this comment.
They won't make a difference since we visit all ImportDecls and ignore the attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, this will now find imports of specific decls (e.g.,
import class XCTest.XCTestCase) and imports inside#ifblocks.Also add some tests specifically for this logic, instead of testing it only in the context of other rules.
Fixes #403.