Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix try/await expressions in NoAssignmentInExpressions. #533

Merged
merged 1 commit into from
May 26, 2023
Merged

Fix try/await expressions in NoAssignmentInExpressions. #533

merged 1 commit into from
May 26, 2023

Commits on May 25, 2023

  1. Fix try/await expressions in NoAssignmentInExpressions. 

    This rule only checked whether the _immediate_ parent of an expression
like `x = y` was a `CodeBlockItem`. In cases like `try x = y`, the `try`
wraps the entire expression and the `CodeBlockItem` would be the parent
of that. So we look through any `TryExpr`s or `AwaitExpr`s we see when
searching for the `CodeBlockItem`.
    @allevato
    allevato committed May 25, 2023
    Configuration menu
    Copy the full SHA
    4fb999d View commit details
    Browse the repository at this point in the history