Fix postfix-#if formatting when they come after a closing parenthesis.
#554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change caused the following formatting, which is less than ideal:
```swift
SomeView(
args
)
#if os(iOS)
.someModifier()
#endif
```
In this case, the `#if` block should be at the same identation level as the
closing parenthesis, similar to how we handle closing braces (`}`).
This change moves the treatment of breaks for postfix-`#if` out of the
visitor for `#if` clauses and instead uses the same contextual break
previsition we use for other member access expressions. The result handles
more cases correctly, and is a simpler, less special-casey implementation.
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Jun 29, 2023
Fix postfix-`#if` formatting when they come after a closing parenthesis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change caused the following formatting, which is less than ideal:
In this case, the
#ifblock should be at the same identation level as the closing parenthesis, similar to how we handle closing braces (}).This change moves the treatment of breaks for postfix-
#ifout of the visitor for#ifclauses and instead uses the same contextual break previsition we use for other member access expressions. The result handles more cases correctly, and is a simpler, less special-casey implementation.