Refactor tests. #595
Merged
Refactor tests. #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR significantly improves the testing infrastructure by adopting the emoji markers used by SwiftSyntax's parser tests. This makes it easier to read and write tests, because the markers indicate in the string where the finding should be emitted and we don't have to compute line/column numbers manually. Additional testing improvements include: - Tests are no longer stateful w.r.t. collecting findings, so a single test can safely call its `assert*` helpers multiple times. - Tests verify the actual text of the findings, not just their symbolic values/constructors. Previously, we weren't actually verifying that the *messages* were what we wanted them to be, and this has revealed a couple minor issues. - I've dropped the `XCT*` prefix on our own custom assertions, because we shouldn't be using their namespace. I've added a handful of FIXME comments for things I caught during the migration that need to be addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly improves the testing infrastructure by adopting the emoji markers used by SwiftSyntax's parser tests. This makes it easier to read and write tests, because the markers indicate in the string where the finding should be emitted and we don't have to compute line/column numbers manually.
Additional testing improvements include:
assert*helpers multiple times.XCT*prefix on our own custom assertions, because we shouldn't be using their namespace.I've added a handful of FIXME comments for things I caught during the migration that need to be addressed.