Allow cross-compiling swift-format #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the file to more modern Python, remove actions that weren’t used anymore and make it more readable in general.
This should build swift-format as a fat binary containing both an x86_64 and an arm64 slice in the open source toolchains.
bnbarham
approved these changes
Jan 23, 2024
| "-rpath", | ||
| "-Xlinker", | ||
| "/usr/lib/swift", | ||
| ] |
There was a problem hiding this comment.
Do we actually need either of the paths after this?
There was a problem hiding this comment.
I’m not sure. I wanted to start with the same paths that sourcekit-lsp uses and then try to simplify the paths again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, I did some cleanup of
build-script-helper.pyfirst. Changes are split into multiple commits.Companion of swiftlang/swift#71042
This should build swift-format as a fat binary containing both an x86_64 and an arm64 slice in the open source toolchains.
The implementation is mostly stolen from
build-script-helper.pyin thesourcekit-lsprepo.rdar://121326143