Skip to content

[6.0] Improve formatting of macro decls with attributes #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2024
Merged

[6.0] Improve formatting of macro decls with attributes #781

merged 1 commit into from
Jul 26, 2024

Conversation

@ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 26, 2024

  • Explanation: Whitespace and newlines were being lost in the token stream when prefixing a macro with an attribute. Call the common attribute handling code, and add a break before the left brace of the decl
  • Scope: Formatting of macro expansion decls
  • Risk: Very narrow change
  • Testing: Added test case
  • Issue: rdar://126948308, Whitespace removed around standalone macro with attribute #689
  • Reviewer: @ahoppen

@shawnhyam @ahoppen
Improve formatting of macro decls with attributes.
53a2680 
Whitespace and newlines were being lost in the token stream when
prefixing a macro with an attribute. Call the common attribute
handling code, and add a break before the left brace of the decl.
@ahoppen ahoppen requested a review from bnbarham July 26, 2024 18:22
@ahoppen ahoppen mentioned this pull request Jul 26, 2024
Draft
@ahoppen ahoppen merged commit 50884c3 into swiftlang:release/6.0 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahoppen @bnbarham @shawnhyam