URL: Don't standardize relative file paths #792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #790 (thanks @nicklockwood for filing!)
We should not standardize the relative path outside of the context of its base URL, such as when calculating the absolute
.path()
. This allows us to properly handle".."
segments at the beginning of the relative path, such as inNote that if the inputted path is absolute, e.g.
"/../images/foo.png"
, we should not resolve against the base URL. I've added a small unit test to cover both cases.