Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cxx-interop] CxxShim files became arch-independent #213

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

egorzhdan
Copy link
Contributor

This adjusts the Windows installation logic after the changes in swiftlang/swift#66765

rdar://110788977

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

platforms/Windows/sdk.wxs Outdated Show resolved Hide resolved
This adjusts the Windows installation logic after the changes in swiftlang/swift#66765

rdar://110788977
@egorzhdan egorzhdan force-pushed the egorzhdan/cxxshim-arch branch from 641588f to 67b1e3a Compare June 22, 2023 15:30
@egorzhdan egorzhdan requested a review from compnerd June 22, 2023 15:32
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to run a build.

@compnerd compnerd merged commit e6e2632 into main Jun 22, 2023
@compnerd compnerd deleted the egorzhdan/cxxshim-arch branch June 22, 2023 19:05
compnerd added a commit to compnerd/swift-installer-scripts that referenced this pull request Jul 27, 2023
This adjusts the Windows installation logic after the changes in swiftlang/swift#66765

rdar://110788977
compnerd added a commit to compnerd/swift-installer-scripts that referenced this pull request Jul 27, 2023
This adjusts the Windows installation logic after the changes in swiftlang/swift#66765

rdar://110788977

Fixes: swiftlang/swift#67462
compnerd added a commit that referenced this pull request Jul 27, 2023
This adjusts the Windows installation logic after the changes in swiftlang/swift#66765

rdar://110788977

Fixes: swiftlang/swift#67462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants