Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiX: adjust the installer UI #236

Merged
merged 1 commit into from
Aug 30, 2023
Merged

WiX: adjust the installer UI #236

merged 1 commit into from
Aug 30, 2023

Conversation

compnerd
Copy link
Member

Adjust the L&F to maintain the aspect ratio that we previously had (4:3). This also adjusts some of the spacing to make it more uniform and adjusts the location of the side banner. The banner is currently shorter than the desired height, but is expected to be replaced with an appropriately sized image soon. It also enables the feature selection items for the ARM64 and X86 SDKs.

@compnerd compnerd requested a review from etcwilde August 30, 2023 00:31
@compnerd
Copy link
Member Author

@lxbndr was kind enough to try to get a resized image from Readdle, which will fix the last of the L&F issues here.

@compnerd
Copy link
Member Author

image
image
image

@compnerd
Copy link
Member Author

CC: @barnson

Adjust the L&F to maintain the aspect ratio that we previously had
(4:3).  This also adjusts some of the spacing to make it more uniform
and adjusts the location of the side banner.  The banner is currently
shorter than the desired height, but is expected to be replaced with an
appropriately sized image soon.  It also enables the feature selection
items for the ARM64 and X86 SDKs.
@compnerd
Copy link
Member Author

image
image
image

With updated assets that @lxbndr will submit separately.

@compnerd
Copy link
Member Author

@compnerd compnerd merged commit 59ca2da into swiftlang:main Aug 30, 2023
@compnerd compnerd deleted the laf branch August 31, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants