format all swift sources, enable format checks #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Oct 25, 2024
| @@ -35,7 +35,7 @@ public func globalTakeIntInt(i: Int, j: Int) { | |||
| p("i:\(i), j:\(j)") | |||
| } | |||
|
|
|||
| public func globalCallMeRunnable(run: () -> ()) { | |||
| public func globalCallMeRunnable(run: () -> Void) { | |||
There was a problem hiding this comment.
c'mon, seriously swift-format? 🤪
(pretty sure that'll break some things since we checked the () -> () string 😅 )
ktoso
commented
Oct 25, 2024
| var funcDecl = ImportedFunc( | ||
| parentName: self.parentName, | ||
| identifier: self.identifier, | ||
| returnType: TranslatedType.void, | ||
| parameters: [.init(param: newValueParam, type: self.returnType)]) | ||
| funcDecl.swiftMangledName = self.swiftMangledName + "s" // form mangled name of the getter by adding the suffix | ||
| funcDecl.swiftMangledName = self.swiftMangledName + "s" // form mangled name of the getter by adding the suffix |
There was a problem hiding this comment.
weird decision by swift-format here...
|
Uncovered fun bug in swift-format: swift-format breaks compilation by wrongly reformatting nested multi-line string blocks swiftlang/swift-format#864 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of those "it has to be done someday" tasks... enabling formatting checking and formatting all Swift sources.
This is just the
swift format Sources --recursive --in-placeinvocation.We can tweak the config if we don't like the output but it'll be nice to have consistent formatting.
WDYT?