[6.0] Import new Bionic module from Android overlay #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on, I need to modify these imports, pull incoming. |
finagolfin
changed the title
dmbryson
approved these changes
Jul 9, 2024
|
@swift-ci please test |
|
Linux CI failed when checking out source. |
|
@swift-ci please test linux |
|
Passed CI, ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Now that this new module and overlay were merged into the 6.0 compiler too in swiftlang/swift#74758, this adds the overlay to the five files that currently
import Glibc.Scope: Add imports on Android only
Issue: None
Original PR: #919 and #921
Risk: None
Testing: Passed all CI on trunk, plus on my daily Android CI, finagolfin/swift-android-sdk#151
Reviewer: @owenv
@ddunbar, let me know what you think.