Skip to content

fix: typo in the word dependency #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Conversation

MojtabaHs
Copy link
Contributor

@MojtabaHs MojtabaHs commented Feb 17, 2025

This change is required by this PR for swift-build repo

Please let me know if we need to introduce a soft deprecation as well.
Thanks

@MojtabaHs MojtabaHs requested a review from dmbryson as a code owner February 17, 2025 08:26
MojtabaHs added a commit to MojtabaHs/swift-build that referenced this pull request Feb 21, 2025
jakepetroules pushed a commit to swiftlang/swift-build that referenced this pull request Feb 21, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* fix: a typo in `dependencyDataFormat`

* fix!: satisfy the protocol requirement.

The fix will be available at swiftlang/swift-llbuild#975
@dmbryson
Copy link
Contributor

Indeed, I suspect the safer route will be to soft deprecate the old method.

@dmbryson
Copy link
Contributor

@swift-ci please smoke test

@dmbryson
Copy link
Contributor

Reading up on the other PR, it sounds like @jakepetroules has recommended the needed path in swift-build. Assuming the tests pass, I think we should be good to go.

@dmbryson
Copy link
Contributor

@swift-ci please smoke test

@jakepetroules
Copy link
Contributor

I think this is ready to land since Swift Build adopted the renamed API a couple months ago now.

@jakepetroules jakepetroules merged commit 19db29b into swiftlang:main Apr 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants