Guard unsafeFlags with Windows-only conditional to restore SwiftPM compatibility (#239) #240
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Bug/issue #239
Summary
This PR addresses the SwiftPM resolution failure introduced in version 0.7.0 where the
Markdowntarget includedunsafeFlagsin itsswiftSettings.On non-Windows platforms (iOS, macOS, Linux), SwiftPM forbids depending on packages that contain unsafe build flags as tagged dependencies, leading to errors like:
the target ‘Markdown’ in product ‘Markdown’ contains unsafe build flagsImplementation overview
swiftSettingsso thatunsafeFlagsare only included when building on Windows.unsafeFlags, restoring SwiftPM compatibility.Dependencies
None.
(Future work may involve updating
swift-cmarkto move theCMARK_GFM_STATIC_DEFINEinto itscSettings.)Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded