[SR-13560] swiftpm: SWIFTPM_MODULE_BUNDLE returning nil

[thomasvl]

Previous ID	SR-13560
Radar	rdar://problem/69090207
Original Reporter	@thomasvl
Type	Bug

Additional Detail from JIRA

Votes	5
Component/s	Package Manager
Labels	Bug
Assignee	None
Priority	Medium

md5: 54f1a590f07af2575ba60b5ea19e1321

is duplicated by:

• SR-13714 'Swift test' fails when including package resources

Issue Description:

An all ObjC package is getting nil from SWIFTPM_MODULE_BUNDLE when using swift test, but if the Package.swift is directly opened in Xcode 12, then the tests pass as the bundle is returned.

Project: https://github.com/google/gtm-session-fetcher
Commit attempt to move the 5.3 Resource support: thomasvl/gtm-session-fetcher@f38d107

Raised in https://forums.swift.org/t/5-3-resources-support-not-working-on-with-swift-test/40381

[neonichu]

@swift-ci create

[BrentMifsud]

also experiencing a related issue with an all Swift Package: SR-13714

[thomasvl]

With 5.5 I'm still getting nil for SWIFTPM_MODULE_BUNDLE

My most recent attempt is on https://github.com/thomasvl/gtm-session-fetcher/tree/swiftpm_updates.

[mokagio]

We run into this issue, too, with 5.5. It can be verified by checking out this commit.

For what is worth, swift tests worked with the 5.3 tools.

[neonichu]

Looks like the implementation is

NSBundle* \(target.c99name)_SWIFTPM_MODULE_BUNDLE() {
            NSURL *bundleURL = [[[NSBundle mainBundle] bundleURL] URLByAppendingPathComponent:@"\(bundleBasename)"];
            return [NSBundle bundleWithURL:bundleURL];
        }

IIRC, the main bundle when executing tests is the test runner, so it makes sense that this would return nil. In Xcode's build system, a more comprehensive implementation is generated that is similar to what we do for Swift.

[ncooke3]

@neonichu, I also ran into this while manually testing #5919. I have proposed a fix for this issue in #5921.