TraitsTests fails when running in 6.1 toolchain #8131
Labels
Comments
dschaefer2
pushed a commit
that referenced
this issue
Nov 21, 2024
Disable assertion in `TraitTests`, which was never executed on macOS due to the self-hosted macOS pipeline running Swift 5.9..2, and test being wrapped around `#if compiler(>=6.0)` pre-processor. ### Motivation: The assertion in `TraitTets` that ensured warnigs do not appear in stderr are failing against the 6.1 toolchain. Since 1) this test was never executed against macOS, since the self-hosted macOS pipeline was running Swift 5.9.2, and 2) work is underway to productive the Traits feature, it was decided to disable the assert for now, and open a GitHub issue to re-enable the assert with the production work. This change removes the assert for GitHub issue 8131, which must be re-enabled when the respective issue is fixed. ### Modifications: Disabled assertion the the `TraitTests` ### Result: ``` swift test --filter "TraitTests" ``` ### NOTE: It is expected the assertions will be re-introduced when #8131 is fixed.
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this issue
Nov 25, 2024
Disable assertion in `TraitTests`, which was never executed on macOS due to the self-hosted macOS pipeline running Swift 5.9..2, and test being wrapped around `#if compiler(>=6.0)` pre-processor. ### Motivation: The assertion in `TraitTets` that ensured warnigs do not appear in stderr are failing against the 6.1 toolchain. Since 1) this test was never executed against macOS, since the self-hosted macOS pipeline was running Swift 5.9.2, and 2) work is underway to productive the Traits feature, it was decided to disable the assert for now, and open a GitHub issue to re-enable the assert with the production work. This change removes the assert for GitHub issue 8131, which must be re-enabled when the respective issue is fixed. ### Modifications: Disabled assertion the the `TraitTests` ### Result: ``` swift test --filter "TraitTests" ``` ### NOTE: It is expected the assertions will be re-introduced when swiftlang#8131 is fixed. (cherry picked from commit dca0cc2)
|
cc @FranzBusch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is it reproducible with SwiftPM command-line tools:
swift build,swift test,swift packageetc?swift build,swift test,swift packageetc.Description
Some of the
TraitsTestsare failing when running against 6.1 toolchain. This is preventing the self-hosted macOS pipeline to upgrade from 5.9 top 6.1 toolchainExpected behavior
All tests in
TraitTestsshould pass. More specifically, theXCTAssertFalse(stderr.contains("warning:"))in each test should not be wrapped in aXCTAssertThrowsError()and should not be commented out. This part of the test may have been updated to allow the test to pass with the 6.x toolchain.Actual behavior
Steps to reproduce
Ensure the
XCTAssertFalse(stderr.contains("warning:"))in the tests are not wrapped in aXCTAssertThrowsError()call, thenSwift Package Manager version/commit hash
cb829d8
Swift & OS version (output of
swift --version ; uname -a)The text was updated successfully, but these errors were encountered: