Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate POSIX #2053

Merged
merged 24 commits into from
Mar 25, 2019
Merged

Eliminate POSIX #2053

merged 24 commits into from
Mar 25, 2019

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Mar 24, 2019

The POSIX module in SwiftPM was written before corelibs-foundation was mature enough. This module provided a great value but isn't good in the long term since we want SwiftPM to be as cross-platform as possible.

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 24, 2019

@swift-ci smoke test

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 24, 2019

@swift-ci smoke test linux

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 24, 2019

@swift-ci smoke test linux

1 similar comment
@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 24, 2019

@swift-ci smoke test linux

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 24, 2019

@swift-ci smoke test linux

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 24, 2019

Dispatch keeps failing with:

15:08:59 <unknown>:0: warning: missing submodule '_SwiftDispatchOverlayShims'
15:08:59 /home/buildnode/jenkins/workspace/swift-package-manager-Linux-smoke-test/swift-corelibs-libdispatch/src/swift/Block.swift:14:8: error: no such module '_SwiftDispatchOverlayShims'
15:08:59 import _SwiftDispatchOverlayShims

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 24, 2019

@swift-ci smoke test linux

1 similar comment
@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 24, 2019

@swift-ci smoke test linux

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 24, 2019

@swift-ci smoke test linux

@aciidgh aciidgh changed the title Remove several things from POSIX Eliminate POSIX Mar 24, 2019
@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 24, 2019

@swift-ci test

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 25, 2019

Ok, got the full swift test suite to run successfully.

@aciidgh aciidgh merged commit 7b98bed into swiftlang:master Mar 25, 2019
@aciidgh aciidgh deleted the processenv branch March 25, 2019 00:28
@therealbnut
Copy link
Contributor

therealbnut commented Mar 25, 2019

@aciidb0mb3r Nice, almost entirely removed the POSIX dependency! 🎉

Sources/swiftpm-manifest-tool/main.swift still contains POSIX.exit (and an import), could that also change to SPMLibc.exit?

After that the only remaining POSIX usage seems to be import enum POSIX.SystemError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants