[PackageLoading] Handle header files in TargetSourcesBuilder #2555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since header files are allowed to be mixed with sources, it makes sense to handle them inside the target sources builder. This allow us to not special case the public headers directory which can lead to weird edge cases with previously supported layouts. This patch also adds two more things 1) diagnostics for duplicate declaration in sources parameter 2) move the explicit resources check to the vNext tools version as resources isn't a Swift 5.2 feature. <rdar://problem/56783465>
|
@swift-ci smoke test |
|
Hi, @aciidb0mb3r Will Xcode 11.4.0 official release with this PR ? I'm a open source project maintainer of SDWebImage and our Swift Package Manager integration get broken because of this issue in the Xcode 11.4-beta... Thanks for your help in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since header files are allowed to be mixed with sources, it makes sense
to handle them inside the target sources builder. This allow us to not
special case the public headers directory which can lead to weird edge
cases with previously supported layouts. This patch also adds two more
things 1) diagnostics for duplicate declaration in sources parameter 2)
move the explicit resources check to the vNext tools version as
resources isn't a Swift 5.2 feature.
rdar://problem/56783465