Skip to content

Pass sdk option to Swift compiler for WASI triples #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

Pass sdk option to Swift compiler for WASI triples #2735

merged 1 commit into from
May 8, 2020

Conversation

MaxDesiatov
Copy link
Contributor

When building for WebAssembly/WASI swiftc needs the -sdk option passed to it with the sdk path.

@MaxDesiatov
Pass sdk option to Swift compiler for WASI triples
f509c31 
When building for WebAssembly/WASI `swiftc` needs the `-sdk` option passed to it with the sdk path.
@MaxDesiatov MaxDesiatov mentioned this pull request May 7, 2020
Closed
78 tasks
@neonichu
Copy link
Contributor

neonichu commented May 7, 2020

@swift-ci please smoke test

@MaxDesiatov
Copy link
Contributor Author

The Linux failures are:

/home/buildnode/jenkins/workspace/swift-package-manager-Linux-smoke-test/branch-master/swiftpm/Tests/PackageLoadingTests/PD4LoadingTests.swift:409: error: PackageDescription4LoadingTests.testEmptyProductTargets : failed - No diagnostics left to check
12:50:53 Test Case 'PackageDescription4LoadingTests.testEmptyProductTargets' failed (0.793 seconds)
12:50:53 Test Suite 'PackageDescription4LoadingTests' failed at 2020-05-07 12:50:36.011
12:50:53 	 Executed 1 test, with 1 failure (0 unexpected) in 0.793 (0.793) seconds
12:50:53 Test Suite 'Selected tests' failed at 2020-05-07 12:50:36.011
12:50:53 	 Executed 1 test, with 1 failure (0 unexpected) in 0.793 (0.793) seconds
12:50:53 
12:50:53 Test Suite 'Selected tests' started at 2020-05-07 12:50:35.193
12:50:53 Test Suite 'PackageDescription4LoadingTests' started at 2020-05-07 12:50:35.195
12:50:53 Test Case 'PackageDescription4LoadingTests.testCTarget' started at 2020-05-07 12:50:35.195
12:50:53 <unknown>:0: warning: missing submodule 'CoreFoundation'
12:50:53 <unknown>:0: error: missing required module 'CoreFoundation'
12:50:53 /home/buildnode/jenkins/workspace/swift-package-manager-Linux-smoke-test/branch-master/swiftpm/Tests/PackageLoadingTests/PDLoadingTests.swift:235: error: PackageDescription4LoadingTests.testCTarget : failed -

Do you think that's related?

@neonichu
Copy link
Contributor

neonichu commented May 7, 2020

Doesn't seem likely to be related, let's try re-running the tests.

@neonichu
Copy link
Contributor

neonichu commented May 7, 2020

@swift-ci please smoke test

@neonichu neonichu merged commit 8e4697d into swiftlang:master May 8, 2020
@MaxDesiatov MaxDesiatov deleted the patch-3 branch May 8, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@aciidgh aciidgh Awaiting requested review from aciidgh

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @neonichu