Disable testPackageManagerDefineAndXArgs

[aschwaighofer]

This test fails spuriously but rather frequently on linux recently.

SR-12902

[aschwaighofer]

@swift-ci Please test

[SDGGiesbrecht]

Thanks for this, @aschwaighofer. I was tearing my hair out trying to figure out how I’d somehow caused this error. It’s a relief to find out it’s not unique to my PR.

[aschwaighofer]

@swift-ci Please test os x platform

[abertelrud]

Disabling this test makes sense if it's generating noise, but I thought that it was an issue that could hit any test. Do we know if this test is doing something wrong that's triggering it, or is being affected by an underlying issue?

[aschwaighofer]

I have only seen it affect this one test on 3 of my PRs and 2 or 3 other PRs that I looked at yesterday
I think @slavapestov is looking at what the root cause is.

I think it still makes sense to disable this test until we have a fix if that reduces the number of failing PRs.

[aschwaighofer]

@swift-ci Please test

[abertelrud]

Great, thanks for the context. I absolutely agree that we should disable the test to avoid more confusion and wasted time, but wanted to understand if we needed to also fix the test. Hopefully if this test triggers it, then it might make it easier to figure out the underlying cause. Thanks!

[abertelrud]

Do you have a JIRA for the underlying bug? I want to create a JIRA for enabling this test and block it on the underlying one.

[aschwaighofer]

I don't have a bug for the underlying bug. @slavapestov Do you have one?

[aschwaighofer]

@swift-ci Please clean test linux

[aschwaighofer]

@swift-ci Please clean test os x

[aschwaighofer]

@swift-ci Please clean test

[aschwaighofer]

@swift-ci Please test

[abertelrud]

Thanks. I created https://bugs.swift.org/browse/SR-12924 to reenable it, and will block that on the underlying JIRA when I find it.

[shahmishal]

Merged to unblock CI