Make module map generation conditional #2891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PIF generation, we were unconditionally generating a module map, but this needs to be conditional on whether `clangTarget.moduleMapPath` exists.
Contributor
Author
|
@swift-ci please smoke test |
jakepetroules
approved these changes
Aug 27, 2020
Contributor
jakepetroules
left a comment
jakepetroules
left a comment
There was a problem hiding this comment.
Looks good, thanks!
abertelrud
approved these changes
Aug 31, 2020
Member
|
Merging to unblock Apple Silicon toolchain. |
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Dec 21, 2020
We merged that PR without a unit test, this adds one. rdar://68158441
neonichu
added a commit
that referenced
this pull request
Dec 22, 2020
federicobucchi
pushed a commit
to federicobucchi/swift-package-manager
that referenced
this pull request
Jan 6, 2021
We merged that PR without a unit test, this adds one. rdar://68158441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PIF generation, we were unconditionally generating a module map, but this needs to be conditional on whether
clangTarget.moduleMapPathexists.