[bootstrap] Add support for cross compile hosts flag #2902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahmishal
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
Member
Author
|
@swift-ci smoke test |
Member
Author
|
cc: @neonichu |
Member
|
Interesting, @neonichu, I have a patch that I use to cross-compile SPM itself from linux x86_64 to Android AArch64 by invoking SPM from an official build of Swift 5.2.5 for Ubuntu with a destination JSON file set up to use the Android NDK. Once this pull is in, would you be interested in a pull that generalized that patch and adapted it to this new flag? |
abertelrud
approved these changes
Sep 1, 2020
Contributor
abertelrud
left a comment
abertelrud
left a comment
There was a problem hiding this comment.
Looks good to me. Seems that it is mainly replacing an env var with a flag. I don't suppose we need to have both, in case something is still setting the env var?
Contributor
|
Don't think we need both, using an env var was just me misunderstanding swift's |
neonichu
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.