deprecate name attribute on package dependencies #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
comes on top of #3635 |
tomerd
force-pushed
the
refactor/package-name
branch
from
0b67b56 to
2b87213
Compare
|
@swift-ci please smoke test |
tomerd
force-pushed
the
refactor/package-name
branch
from
2b87213 to
57bf96e
Compare
|
@swift-ci please smoke test |
tomerd
force-pushed
the
refactor/package-name
branch
2 times, most recently
from
5c0794c to
019d09f
Compare
|
@swift-ci please smoke test |
tomerd
force-pushed
the
refactor/package-name
branch
from
019d09f to
edeb78c
Compare
|
@swift-ci please smoke test |
motivation: follow on work to the change in 5.5 that _allows_ users to not specify a name on the dependency, this soft-deprecates the ability to do so changes: * emit a deprecation warning when using the name attribute on a dependency (in the manifest) * refactor the depedency::name attribute to "deprecatedName" to reflect the fact it was deprecated and prevert too much downstream logic * cleanup the internal API * cleanup and add tests
tomerd
force-pushed
the
refactor/package-name
branch
from
edeb78c to
7fc19bd
Compare
|
@swift-ci please smoke test |
tomerd
added
the
ready
|
@swift-ci please smoke test |
tomerd
commented
Aug 4, 2021
| } | ||
| } | ||
|
|
||
| func testLanguageStandards() { | ||
| guard Resources.havePD4Runtime else { return } |
There was a problem hiding this comment.
@abertelrud removed these at it seems like leftover from before we removed PD4?
There was a problem hiding this comment.
Yes, I think you're correct.
abertelrud
approved these changes
Aug 4, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: follow-on work to the change in 5.5 that allows users to not specify a name on the dependency, this soft-deprecates the ability to do so
changes: