optimize manifest requests for registry based depedendcies #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: improve performance by reducing redundant http calls changes: * save main manifest on first request * cache known manifest across calls in RegistryPackageContainer * add RegistryPackageContainer tests * fix a bug in workspace where custom tools version is not propogated to the toolsLoader rdar://86218181
tomerd
force-pushed
the
radar/86218181
branch
from
a8a0e22 to
4393c9e
Compare
|
@swift-ci please smoke test |
tomerd
commented
Dec 10, 2021
| @@ -290,7 +290,7 @@ public class Workspace { | |||
| ) throws { | |||
| // defaults | |||
| let currentToolsVersion = customToolsVersion ?? ToolsVersion.currentToolsVersion | |||
| let toolsVersionLoader = ToolsVersionLoader() | |||
| let toolsVersionLoader = ToolsVersionLoader(currentToolsVersion: currentToolsVersion) | |||
There was a problem hiding this comment.
customToolsVersion should only be used in tests, we should probably remove it from the public constructor and move it into an internal one
tomerd
added
the
ready
yim-lee
approved these changes
Dec 11, 2021
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Dec 11, 2021
…#3929) motivation: improve performance by reducing redundant http calls changes: * save main manifest on first request * cache known manifest across calls in RegistryPackageContainer * add RegistryPackageContainer tests * fix a bug in workspace where custom tools version is not propogated to the toolsLoader rdar://86218181
This was referenced Dec 11, 2021
tomerd
added a commit
that referenced
this pull request
Dec 13, 2021
…3934) motivation: improve performance by reducing redundant http calls changes: * save main manifest on first request * cache known manifest across calls in RegistryPackageContainer * add RegistryPackageContainer tests * fix a bug in workspace where custom tools version is not propogated to the toolsLoader rdar://86218181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: improve performance by reducing redundant http calls
changes:
rdar://86218181