[Linux] Teach SwiftPM how to handle actor-isolated test functions #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f test function signature (e.g. actor-isolated functions.)
grynspan
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci please smoke test |
tomerd
reviewed
May 18, 2022
| class MainActorIsolatedTestCaseTests: XCTestCase { | ||
| @MainActor | ||
| func test_actorIsolatedToMain() { } | ||
| } |
There was a problem hiding this comment.
this is a clever way to test, but probably best to create a fixture instead: see FunctionalTests/TestDiscoveryTests for examples on how to set such up
There was a problem hiding this comment.
Sounds good, will refactor.
|
Build failure does not appear related to my changes (timeout?) |
|
looks like its failing on the change: |
|
Blergh, fair. I think that's using the deprecated path? I can make the same change on that path but I'm not sure when one path or the other is used. Any thoughts? |
|
i guess if you remove these tests and instead make them into a fixture, then that would use the just-built SwiftPM to run those and should help resolve it? |
|
@grynspan do you need any more information on how to create such fixture? |
|
I might—I have had to change focus and haven't been looking at this PR but will come back to it when I can. |
|
I need to circle back to this at some point! |
jshier
pushed a commit
to Alamofire/Alamofire
that referenced
this pull request
Jan 7, 2025
### Goals ⚽ This PR restores the Linux and Android build actions, which were disabled in #3920. It also updates the Android build action to use [swift-android-action@v2](https://github.com/marketplace/actions/swift-android-action), which enables it to run on Linux rather than requiring macOS. ### Implementation Details 🚧 Linux and Android toolchains cannot build test methods annotated with `@MainActor`, as discussed at swiftlang/swift-package-manager#5525. Rather than disabling building the tests, we instead trim out the `@MainActor` declarations with a simple `sed` command prior to performing the build on those platforms. ### Testing Details 🔍 I didn't add or remove any tests. The builds at passing in my fork for [Android](https://github.com/marcprux/Alamofire/actions/runs/12614003719/job/35152459756) and [Linux](https://github.com/marcprux/Alamofire/actions/runs/12614003719/job/35152460366).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change teaches SwiftPM how to handle actor-isolated test cases in a package on Linux.
Motivation:
Given the following
XCTestCasesubclass:Or this one:
SwiftPM currently does not handle them properly, leading to a build error when compiling the test suite of the form:
Modifications:
This change emits a helper function into the synthesized test binary that takes either a synchronous or asynchronous member function of a test case class and returns a function of the appropriate form. It then uses that function when synthesizing the
__allTests__array instead of trying to check if a functionisAsync.Since a function of the form
@MainActor func testX() { }lives in the twilight zone between sync andasync, but can be trivially converted to anasyncfunction (with a synthesized thunk), this allows such functions to be added to the array in question.Result:
This change should allow test suites with actor-isolated tests to build and be tested successfully.