Use repository cache without update if offline #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On macOS, we could use SCNetworkReachability to determine reachability after catching the error. |
neonichu
force-pushed
the
use-cache-without-update-if-offline
branch
from
8cfcacf to
5769690
Compare
neonichu
changed the title
|
Updated this to a reasonable state, at least for macOS. Tested manually that we can reuse the cache if present and that we get the same error as today if not. |
|
@swift-ci please smoke test |
tomerd
approved these changes
Oct 20, 2022
If there's an error populating the cache, check whether we're offline and have an existing valid repository state. If yes, use cached state and emit a warning. On macOS, we're using network reachability to determine the connection status, on other platforms we rely on crude parsing of the git error message for now.
neonichu
force-pushed
the
use-cache-without-update-if-offline
branch
from
5769690 to
3adb292
Compare
|
@swift-ci please smoke test |
tomerd
approved these changes
Oct 27, 2022
abertelrud
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's an error populating the cache, check whether we're offline and have an existing valid repository state. If yes, use cached state and emit a warning.
On macOS, we're using network reachability to determine the connection status, on other platforms we rely on crude parsing of the git error message for now.