Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftTool: refine wording in func *UpdateRepository #5836

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

SwiftTool: refine wording in func *UpdateRepository #5836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Commands/SwiftTool.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,11 @@ private class ToolWorkspaceDelegate: WorkspaceDelegate {
}

func willUpdateRepository(package: PackageIdentity, repository url: String) {
self.outputHandler("Updating \(url)", false)
self.outputHandler("Checking for updates from \(url)", false)
}

func didUpdateRepository(package: PackageIdentity, repository url: String, duration: DispatchTimeInterval) {
self.outputHandler("Updated \(url) (\(duration.descriptionInSeconds))", false)
self.outputHandler("Checked for updates from \(url) (\(duration.descriptionInSeconds))", false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should remain "Updated", as we may have updated. We could / should modify this delegate to include the modified: Bool argument, but not sure how easy or hard that would be

}

func dependenciesUpToDate() {
Expand Down