Skip testCompilationDiagnostics on certain failures
#6076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing some failures in Swift CI that look similar to the compiler issue being worked around in #5659. For now, we will not assert if that particular part of the test fails and instead use `XCTSkip` plus log the bytes of the serialized diagnostics to the console. rdar://96517321
|
@swift-ci please smoke test |
tomerd
approved these changes
Jan 25, 2023
|
macOS failures look like infra issues to me. |
|
@swift-ci please smoke test macOS |
abertelrud
added a commit
to abertelrud/swift-package-manager
that referenced
this pull request
Jan 27, 2023
…at it doesn't throw if there are no diagnostics at all reported This is a follow-on to swiftlang#6076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing some failures in Swift CI that look similar to the compiler issue being worked around in #5659. For now, we will not assert if that particular part of the test fails and instead use
XCTSkipplus log the bytes of the serialized diagnostics to the console.rdar://96517321