Plugin import scanner isn't passing in the library directory, making canImport not work
#6323
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Workspace type has a facility for scanning package plugins for imports. But since it's not passing in the actual plugin directory provided by the caller (whether it's SwiftPM or Xcode), any modules provided by an IDE aren't picked up if they are guarded by `#if canImport()`. This includes `XcodeProjectPlugin`, which is one of the additional plugin modules provided by Xcode. The same would be true for other IDEs. Changes: - `Workspace.loadPluginImports` now also passes the path of the plugin directory to the import scanning - extended the `testScanImportsInPluginTargets` unit test to check for this case rdar://106387043
|
cc @neonichu |
|
@swift-ci please smoke test |
neonichu
approved these changes
Mar 24, 2023
abertelrud
added a commit
to abertelrud/swift-package-manager
that referenced
this pull request
Mar 24, 2023
…ng#6323) The Workspace type has a facility for scanning package plugins for imports. But since it's not passing in the actual plugin directory provided by the caller (whether it's SwiftPM or Xcode), any modules provided by an IDE aren't picked up if they are guarded by `#if canImport()`. This includes `XcodeProjectPlugin`, which is one of the additional plugin modules provided by Xcode. The same would be true for other IDEs. Changes: - `Workspace.loadPluginImports` now also passes the path of the plugin directory to the import scanning - extended the `testScanImportsInPluginTargets` unit test to check for this case rdar://106387043 (cherry picked from commit e3b6e5d)
tomerd
pushed a commit
that referenced
this pull request
Mar 24, 2023
…6326) The Workspace type has a facility for scanning package plugins for imports. But since it's not passing in the actual plugin directory provided by the caller (whether it's SwiftPM or Xcode), any modules provided by an IDE aren't picked up if they are guarded by `#if canImport()`. This includes `XcodeProjectPlugin`, which is one of the additional plugin modules provided by Xcode. The same would be true for other IDEs. Changes: - `Workspace.loadPluginImports` now also passes the path of the plugin directory to the import scanning - extended the `testScanImportsInPluginTargets` unit test to check for this case rdar://106387043 (cherry picked from commit e3b6e5d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Workspace type has a facility for scanning package plugins for imports. But since it's not passing in the actual plugin directory provided by the caller (whether it's SwiftPM or Xcode), any modules provided by an IDE aren't picked up if they are guarded by
#if canImport(). This includesXcodeProjectPlugin, which is one of the additional plugin modules provided by Xcode. The same would be true for other IDEs.Changes:
Workspace.loadPluginImportsnow also passes the path of the plugin directory to the import scanningtestScanImportsInPluginTargetsunit test to check for this caserdar://106387043