Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: fix duplicate case of switch in BuildPlan.swift #6389

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Apr 5, 2023

The way this switch is written currently triggers a warning:

/Build/BuildPlan.swift:770:22: warning: case is already handled by previous patterns; consider removing it
                case .macro:

Since this case .macro on line 770 is never reached due to another case .macro covering it above on line 737, it seems safe to remove the unused case altogether.

@MaxDesiatov MaxDesiatov self-assigned this Apr 5, 2023
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay. @neonichu ptal

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos self-hosted

@MaxDesiatov MaxDesiatov merged commit 76549ad into main Apr 17, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/fix-duplicate-case branch April 17, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants