Add author and signer to package collection models #6415
Merged
+258
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Package collection should have information about how a version was created. This includes the creator and signer. swiftlang#6408 added `author` populated using GitHub data, but we can allow package collection author to specify version creator as well. rdar://106674475 Modifications: - Add `author` and `signer` to package collection models - Update `PackageSearchClient` to use more information from collection/index results
|
@swift-ci please smoke test |
yim-lee
commented
Apr 12, 2023
| @@ -657,7 +657,8 @@ public struct PackageCollections: PackageCollectionsProtocol, Closable { | |||
| defaultToolsVersion: packageVersion.defaultToolsVersion, | |||
| verifiedCompatibility: packageVersion.verifiedCompatibility, | |||
| license: packageVersion.license, | |||
| author: versionMetadata?.author, | |||
| author: versionMetadata?.author ?? packageVersion.author, | |||
There was a problem hiding this comment.
Author info can come from GitHub or package collection
| description: latestVersion?.summary, | ||
| publishedAt: latestVersion?.createdAt, | ||
| signingEntity: latestVersion?.signer.map { SigningEntity(signer: $0) }, | ||
| latestVersion: latestVersion?.version, |
There was a problem hiding this comment.
I think we can set some of these using the package's latest version listed in the collection/index result.
neonichu
approved these changes
Apr 12, 2023
|
@swift-ci please test Windows platform |
yim-lee
added a commit
to yim-lee/swift-package-collection-generator
that referenced
this pull request
Apr 12, 2023
Motivation: A package version in a package collection can have `signer`, which was added swiftlang/swift-package-manager#6415 Modification: Add `signer` to package level input. If set, all versions of the package will have that `signer`.
yim-lee
added a commit
to yim-lee/swift-package-collection-generator
that referenced
this pull request
Apr 12, 2023
Motivation: A package version in a package collection can have `signer`, which was added swiftlang/swift-package-manager#6415 Modification: Add `signer` to package level input. If set, all versions of the package will have that `signer`.
yim-lee
added a commit
to swiftlang/swift-package-collection-generator
that referenced
this pull request
Apr 13, 2023
Motivation: A package version in a package collection can have `signer`, which was added swiftlang/swift-package-manager#6415 Modification: Add `signer` to package level input. If set, all versions of the package will have that `signer`.
yim-lee
added a commit
to swiftlang/swift-package-collection-generator
that referenced
this pull request
Apr 13, 2023
Motivation: A package version in a package collection can have `signer`, which was added swiftlang/swift-package-manager#6415 Modification: Add `signer` to package level input. If set, all versions of the package will have that `signer`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Package collection should have information about how a version was created. This includes the creator and signer.
#6408 added
authorpopulated using GitHub data, but we can allow package collection author to specify version creator as well.rdar://106674475
Modifications:
authorandsignerto package collection modelsPackageSearchClientto use more information from collection/index results