quiet down redundant warnings for binary targets with multiple info.plist #6445
+278
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list motivation: better ux changes: * change un-parsable info.plist warning to debug since its a valid use case and the warning is intended mainly for deubg purposes * add informational diagnostics with the details of the found the binary artifact * formatting rdar://107669671
tomerd
requested review from
abertelrud,
neonichu and
MaxDesiatov
as code owners
tomerd
commented
Apr 17, 2023
| @@ -521,7 +692,7 @@ extension Workspace.BinaryArtifactsManager { | |||
| _ = try decoder.decode(XCFrameworkMetadata.self, from: fileSystem.readFileContents(infoPlist)) | |||
| return .xcframework | |||
| } catch { | |||
| observabilityScope.emit(warning: "info.plist found in '\(path)' but failed to parse: \(error)") | |||
| observabilityScope.emit(debug: "info.plist found in '\(path)' but failed to parse: \(error)") | |||
tomerd
commented
Apr 17, 2023
| return binaryArtifact | ||
| } else if let binaryArtifact = binaryArtifacts.first { | ||
| // single one | ||
| observabilityScope.emit(info: "found binary artifact: '\(binaryArtifact)'") |
|
@swift-ci smoke test |
neonichu
approved these changes
Apr 17, 2023
|
@swift-ci smoke test macOS |
1 similar comment
|
@swift-ci smoke test macOS |
MaxDesiatov
approved these changes
Apr 18, 2023
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Apr 18, 2023
…list (swiftlang#6445) motivation: better ux changes: * change un-parsable info.plist warning to debug since its a valid use case and the warning is intended mainly for deubg purposes * add informational diagnostics with the details of the found the binary artifact * formatting rdar://107669671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: better ux
changes:
rdar://107669671