Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM: test 5.8 PR #6455

Closed
wants to merge 1 commit into from
Closed

DNM: test 5.8 PR #6455

wants to merge 1 commit into from

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Apr 19, 2023

test 5.8 branch

@tomerd
Copy link
Contributor Author

tomerd commented Apr 19, 2023

@swift-ci smoke test

@tomerd tomerd mentioned this pull request Apr 19, 2023
Merged
@finagolfin
Copy link
Member

Yep, same test failed.

@tomerd
Copy link
Contributor Author

tomerd commented Apr 19, 2023

@neonichu @abertelrud is this test expected to fail on 5.8. should we xfail it on this branch?

@neonichu
Copy link
Contributor

xfail sounds reasonable

@tomerd
Copy link
Contributor Author

tomerd commented Apr 19, 2023

#6458

@tomerd tomerd changed the title DNM: test PR DNM: test 5.8 PR Apr 19, 2023
@tomerd tomerd added the swift 5.8 This PR targets the 5.8 branch label Apr 19, 2023
@tomerd tomerd closed this Apr 19, 2023
@neonichu neonichu deleted the tomerd-patch-2 branch April 19, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abertelrud abertelrud Awaiting requested review from abertelrud abertelrud is a code owner

@neonichu neonichu Awaiting requested review from neonichu neonichu is a code owner

@elsh elsh Awaiting requested review from elsh elsh is a code owner

Assignees
No one assigned
Labels
swift 5.8 This PR targets the 5.8 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomerd @finagolfin @neonichu