Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Only show command output in verbose mode (#7078)" #7130

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Revert "Only show command output in verbose mode (#7078)" #7130

merged 1 commit into from
Nov 28, 2023

Conversation

MaxDesiatov
Copy link
Contributor

Motivation:

With recent changes linker/compiler errors are silently consumed and don't appear in stdout or stderr.

Modifications:

This reverts commit 4c35491.

Result:

Resolves #7114.

@MaxDesiatov MaxDesiatov self-assigned this Nov 28, 2023
@MaxDesiatov MaxDesiatov mentioned this pull request Nov 28, 2023
Merged
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov merged commit 6e07c93 into main Nov 28, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/revert-command-output branch November 28, 2023 18:51
MaxDesiatov added a commit that referenced this pull request Nov 29, 2023
@MaxDesiatov
[5.10] Revert "Only show command output in verbose mode (#7078)" (#7131)
5d9baaf 
Cherry-pick of #7130.

### Motivation:

With recent changes linker/compiler errors are silently consumed and
don't appear in stdout or stderr.

### Modifications:

This reverts commit 4c35491.

### Result:

Resolves #7114.
@neonichu neonichu mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

@neonichu neonichu Awaiting requested review from neonichu

Assignees

@MaxDesiatov MaxDesiatov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linker/compiler errors are silently consumed and don't appear in stdout or stderr
2 participants
@MaxDesiatov @tomerd