Rename the swift-testing entry point. #7137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR renames the entry point function used by SwiftPM to call into swift-testing such that it does not need to be SPI. By marking it SPI, we unintentionally made it very difficult to use with a toolchain that does not include private module information. swift-testing will continue to export the old symbol name as used by SwiftPM until this change has firmly landed in toolchains, after which we will remove the old function.
grynspan
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
2 tasks
|
@swift-ci please test |
neonichu
approved these changes
Nov 29, 2023
stmontgomery
approved these changes
Nov 29, 2023
tomerd
approved these changes
Nov 29, 2023
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Nov 29, 2023
This PR removes the `@_spi(SwiftPackageManagerSupport)`-annotated `swiftPMEntryPoint()` function now that SwiftPM has adopted the newer synonym, `__swiftPMEntryPoint()`. Blocked by swiftlang/swift-package-manager#7137.
2 tasks
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Dec 4, 2023
This PR removes the `@_spi(SwiftPackageManagerSupport)`-annotated `swiftPMEntryPoint()` function now that SwiftPM has adopted the newer synonym, `__swiftPMEntryPoint()`. Blocked by swiftlang/swift-package-manager#7137.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the entry point function used by SwiftPM to call into swift-testing such that it does not need to be SPI. By marking it SPI, we unintentionally made it very difficult to use with a toolchain that does not include private module information.
swift-testing will continue to export the old symbol name as used by SwiftPM until this change has firmly landed in toolchains, after which we will remove the old function.
See: swiftlang/swift-testing#141