Allow specifying testing libraries for swift package init
#7186
+295
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `-enable-experimental-swift-testing` (and `-disable-xctest` and their inverses) to `swift package init`. These options behave, broadly, the same as they do for `swift test`. They determine which testing library a new package will use and adjust the generated template to match. It is important to note that any combination of the two libraries is supported: a developer may wish to use only one or the other, or both, or may wish to opt out of a test target entirely. All four combinations are supported, however for simplicity's sake if both libraries are enabled, we only generate example code for swift-testing. Note that right now, correct macro target support is impeded by swiftlang/swift-syntax#2400. I don't think that issue blocks a change here (since it's in an experimental feature anyway!) but it does mean that `swift package init --type macro --enable-experimental-swift-testing` produces some dead tests. Once that issue is resolved, we can revise the template to produce meaningful tests instead. Resolves rdar://99279056.
grynspan
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please test |
|
Thinking about it, replacement API in swift-syntax won't have an associated tag for a while anyway, so we definitely shouldn't block on it. |
|
I think |
|
We can certainly do that. |
|
@swift-ci please test |
|
@swift-ci test windows |
MaxDesiatov
reviewed
Dec 12, 2023
MaxDesiatov
reviewed
Dec 12, 2023
MaxDesiatov
approved these changes
Dec 12, 2023
MaxDesiatov
changed the title
MaxDesiatov
changed the title
swift package init
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please clean test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
-enable-experimental-swift-testing(and-disable-xctestand their inverses) toswift package init. These options behave, broadly, the same as they do forswift test. They determine which testing library a new package will use and adjust the generated template to match.It is important to note that any combination of the two libraries is supported: a developer may wish to use only one or the other, or both, or may wish to opt out of a test target entirely. All four combinations are supported, however for simplicity's sake if both libraries are enabled, we only generate example code for swift-testing.
Note that right now, correct macro target support is impeded by swiftlang/swift-syntax#2400. I don't think that issue blocks a change here (since it's in an experimental feature anyway!) but it does mean that
swift package init --type macro --enable-experimental-swift-testingproduces some dead tests. Once that issue is resolved, we can revise the template to produce meaningful tests instead.Resolves rdar://99279056.