build: enable vendoring dependencies #7199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
This is using a personal branch for swift-certificates as this is waiting on apple/swift-certificates#158 (CC: @yim-lee) |
MaxDesiatov
added
dependencies
etcwilde
reviewed
Dec 13, 2023
| set(BUILD_EXAMPLES NO) | ||
| set(BUILD_TESTING NO) | ||
|
|
||
| find_package(ArgumentParser CONFIG) |
There was a problem hiding this comment.
Do you need to explicitly call find_package first? If you don't do anything FetchContent will call find_package first before doing anything, and only if it's not found will it do things. To tell it to use the CONFIG search mode, add do
FetchContent_Declare(ArgumentParser
GIT_REPOSITORY https://github.com/apple/swift-argument-parser
GIT_TAG 1.2.3
FIND_PACKAGE_ARGS CONFIG)https://cmake.org/cmake/help/latest/module/FetchContent.html#command:fetchcontent_declare -- FIND_PACKAGE_ARGS
erm... wait, that's only available in 3.24+. That makes things more challenging.
There was a problem hiding this comment.
I think I'll leave this as is until we get a newer CMake.
|
@swift-ci please test |
neonichu
reviewed
Jan 31, 2024
neonichu
reviewed
Jan 31, 2024
neonichu
reviewed
Jan 31, 2024
Setup the support for building SPM with vendored dependencies. This is preparatory work to enable the build of the LSP which is not possible to build with SPM on Windows and thus prevented from being able to be built and debugged outside of the toolchain build.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup the support for building SPM with vendored dependencies. This is preparatory work to enable the build of the LSP which is not possible to build with SPM on Windows and thus prevented from being able to be built and debugged outside of the toolchain build.