Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust testURLBasedPluginAPI logging checks #7205

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

neonichu
Copy link
Contributor

It seems like there's some flakiness with these log statements on Linux, but since they're not material for the test (which mostly wants to test that the build succeeds), we can remove the assertions for them for now to avoid blocking CI.

It seems like there's some flakiness with these log statements on Linux, but since they're not material for the test (which mostly wants to test that the build succeeds), we can remove the assertions for them for now to avoid blocking CI.
@neonichu neonichu self-assigned this Dec 18, 2023
@neonichu
Copy link
Contributor Author

@swift-ci please test

@MaxDesiatov MaxDesiatov changed the title Adjust testURLBasedPluginAPI Adjust testURLBasedPluginAPI logging checks Dec 18, 2023
@MaxDesiatov MaxDesiatov added test suite improvements to SwiftPM test suite plugins labels Dec 18, 2023
@neonichu
Copy link
Contributor Author

Hm, interesting, seems like a lot of tests are failing on Linux self-hosted?

Test Case 'BuildToolTests.testBuildStartMessage' started at 2023-12-18 17:42:12.384
**** FAILURE EXECUTING SUBPROCESS ****
output: 
stderr: error: 'dependencyresolution_internal_simple': Invalid manifest (compiled with: ["/home/build-user/latest_toolchain/swift-DEVELOPMENT-SNAPSHOT-2023-12-17-a-ubuntu20.04/usr/bin/swiftc", "-vfsoverlay", "/tmp/TemporaryDirectory.8iHWxo/vfs.yaml", "-L", "/home/build-user/swiftpm/.build/x86_64-unknown-linux-gnu/debug", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/home/build-user/swiftpm/.build/x86_64-unknown-linux-gnu/debug", "-swift-version", "4.2", "-I", "/home/build-user/swiftpm/.build/x86_64-unknown-linux-gnu/debug", "-package-description-version", "4.2.0", "-module-cache-path", "/home/build-user/swiftpm/.build/x86_64-unknown-linux-gnu/debug", "/tmp/DependencyResolution_Internal_Simple.jpYwHJ/DependencyResolution_Internal_Simple/Package.swift", "-Xfrontend", "-disable-implicit-concurrency-module-import", "-Xfrontend", "-disable-implicit-string-processing-module-import", "-o", "/tmp/TemporaryDirectory.p2FAVq/dependencyresolution_internal_simple-manifest"])
error: fatalError
/tmp/DependencyResolution_Internal_Simple.jpYwHJ/DependencyResolution_Internal_Simple/Package.swift:3:8: error: no such module 'PackageDescription'
import PackageDescription
       ^

@neonichu
Copy link
Contributor Author

Confirmed here that the issue is present in baseline and it seems like macOS is passing. Since builds were passing on Friday, most likely culprit seems to be the toolchain?

@neonichu
Copy link
Contributor Author

Interesting that we're not seeing the issue on Linux smoke test.

@atrick atrick merged commit 5f85bff into main Dec 19, 2023
@atrick atrick deleted the adjust-testURLBasedPluginAPI branch December 19, 2023 23:12
@tomerd
Copy link
Contributor

tomerd commented Dec 20, 2023

@atrick @neonichu feels like merging this papers over something else that has changed in the compiler / driver and may be a problem

@neonichu
Copy link
Contributor Author

@tomerd it's a new test, so likely not any change, but I agree that it is interesting to figure out why we have inconsistent logging on Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins test suite improvements to SwiftPM test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants