Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subsetDescriptor to completion message #7208

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

neonichu
Copy link
Contributor

If we build just a specific product or target, add a subsetDescriptor to the complete message. This improves the confusing output when plugins are using executables, because we end up with multiple 'Build complete' messages.

@neonichu neonichu self-assigned this Dec 19, 2023
@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

Looks like a few tests need updates.

@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

@swift-ci please test windows

@neonichu
Copy link
Contributor Author

Looks like I missed something in IntegrationTests.

If we build just a specific product or target, add a `subsetDescriptor` to the complete message. This improves the confusing output when plugins are using executables, because we end up with multiple 'Build complete' messages.
@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

@swift-ci please test windows

@neonichu
Copy link
Contributor Author

@swift-ci please test linux

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MaxDesiatov MaxDesiatov added enhancement swift build Changes impacting `swift build` labels Jan 2, 2024
@neonichu neonichu merged commit 3ce3894 into main Jan 2, 2024
@neonichu neonichu deleted the subsetDescriptor branch January 2, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement swift build Changes impacting `swift build`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants